-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PGN reader is not compatible with cutechess-cli #78
Comments
Fixes issue notnil#78
@amanjpro after reviewing the issue, it appears that the previous code only handles comments with spaces. |
I agree it's a hack, I only did it to unblock myself for my engine... I appreciate a cleaner solution :) I love this library and will soon use it for my other projects ;) |
There were two main bugs that this fixes. * Fixes notnil#77: fixed parsing of PGNs where there is no space after the move number indicator. This used to work, but notnil#76 caused a regression. * Fixes notnil#78: using the regular expression allows for comments that don't have spaces separating the `{` and `}` tokens.
Reading this PGN:
Will result in this error:
The text was updated successfully, but these errors were encountered: