Add support for nil move in Position.Update #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thanks for the awesome library! I'm using it to write a toy chess engine.
Then, this PR:
Position.Updateis useful for game engines when also using theValidMovesmethod as it skips redundant validation. It would also be useful to add support for nil move to make it act like passing is a thing in chess.This could be used in the context of implementing null move pruning or in quiescence search to check if not capturing is better than capturing.
Currently, when passed nil
Position.Updatepanics. The proposal is that when passed nil, it returns the same position with the opposite turn.