Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ECDSA signatures are not generated correctly #21

Closed
jurriaan opened this issue Jun 23, 2015 · 1 comment
Closed

ECDSA signatures are not generated correctly #21

jurriaan opened this issue Jun 23, 2015 · 1 comment

Comments

@jurriaan
Copy link

You cannot use the private_key.dsa_sign_asn1 output directly as signature. The JWS signature consists of the concatenated R and S integers. RFC7515 appendix A.3.1

See also jwt/ruby-jwt#87 and jwt/ruby-jwt#84
nov added a commit that referenced this issue Jun 23, 2015
@nov
confirmed my JWS ECDSA implementation is wrong.
276815f 
ref #21
@kookster kookster mentioned this issue Jul 2, 2015
Merged
@nov nov closed this as completed Jul 7, 2015
@nov
Copy link
Owner

nov commented Jul 7, 2015

I hope my fix works for you.
If you still has issues, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nov @jurriaan