Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Please have TMDB multimedia information in Traditional Chinese version #1129

Open
hellotaeyeon0214 opened this issue Feb 16, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request Important Bug severity

Comments

@hellotaeyeon0214
Copy link

Description

Please have TMDB multimedia information in Traditional Chinese version

Additional information

No response

@hellotaeyeon0214 hellotaeyeon0214 added the enhancement New feature or request label Feb 16, 2024
@courville
Copy link
Contributor

courville commented Feb 17, 2024

First, note that you can chose the scraping language in the nova settings under the scrape section for movies and series and you can manually set it.

Now you need to find the right item for Traditional Chinese.

There I can use some help: according to https://developer.themoviedb.org/reference/configuration-languages, the full list of supported languages are in the form of two letters code ISO639-1:

aa|ab|ae|af|ak|am|an|ar|as|av|ay|az|ba|be|bg|bi|bm|bn|bo|br|bs|ca|ce|ch|cn|co|cr|cs|cu|cv|cy|da|de|dv|dz|ee|el|en|eo|es|et|eu|fa|ff|fi|fj|fo|fr|fy|ga|gd|gl|gn|gu|gv|ha|he|hi|ho|hr|ht|hu|hy|hz|ia|id|ie|ig|ii|ik|io|is|it|iu|ja|jv|ka|kg|ki|kj|kk|kl|km|kn|ko|kr|ks|ku|kv|kw|ky|la|lb|lg|li|ln|lo|lt|lu|lv|mg|mh|mi|mk|ml|mn|mr|ms|mt|my|na|nb|nd|ne|ng|nl|nn|no|nr|nv|ny|oc|oj|om|or|os|pa|pi|pl|ps|pt|qu|rm|rn|ro|ru|rw|sa|sc|sd|se|sg|sh|si|sk|sl|sm|sn|so|sq|sr|ss|st|su|sv|sw|ta|te|tg|th|ti|tk|tl|tn|to|tr|ts|tt|tw|ty|ug|uk|ur|uz|ve|vi|vo|wa|wo|xh|yi|yo|za|zh|zu

You see that you do not find the zh-cn (Chinese) and zh-tw (Traditional Chinese) classical ones.

Referring https://en.wikipedia.org/wiki/List_of_ISO_639_language_codes for the zoology of ISO639 codes, I figured that cn and zh are related to Chinese language as a whole.

"Funny" thing is that cn is not a ISO639-1 code. After some search to treat these exceptions, I made the correspondance to map cn to the 3 letters code ISO639-3 yue which is Cantonese.
Please forgive my ignorance but I associated Cantonese in my mind to Traditional Chinese (or another non existing ISO639-1 code zt) but I left the translation of yue to the Android system and thus I have no clue how it appears in the nova scrape language setting menu.

Could you tell me if my interpretation is correct: i.e. cn=yue? And if I need to force cn naming to Traditional Chinese (for now it should appear as Cantonese in the language list)?

Note that, for the little story non related to TMDb, opensubtitles uses the non standard zht code for Traditional Chinese that I mapped manually to the Traditional Chinese string as an exception.

@courville courville self-assigned this Feb 17, 2024
@courville courville added the Important Bug severity label Feb 17, 2024
courville added a commit to nova-video-player/aos-MediaLib that referenced this issue Feb 17, 2024
@courville
Copy link
Contributor

Please confirm you agree with analysis and fix (cn is Traditional Chinese) by selecting Cantonese as language in scape section and verifying that indeed it results in Traditional Chinese movies/shows descriptions.

@courville
Copy link
Contributor

@hellotaeyeon0214
Copy link
Author

hellotaeyeon0214 commented Feb 18, 2024

@hellotaeyeon0214請在https://github.com/nova-video-player/aos-AVP/releases/tag/v6.2.62上提供回饋

(Use google translate traditional Chinese to English, sorry)

I selected Traditional Chinese and re-captured it, but the poster changed to the original language and the introduction narrative was in English.

I have entered the TMDB website and selected unreleased movies as an example.

Cantonese (mostly used in Hong Kong and Macau)
HK

Traditional Chinese (used in Taiwan)
TW

(Both are similar but not quite the same)

The subtitles are in Traditional Chinese but the subtitles in the video are in Simplified Chinese.

@courville
Copy link
Contributor

courville commented Aug 17, 2024

@hellotaeyeon0214 sorry for the late reply on this.
Thanks for your help in getting the right mapping between Traditional and Simplified Chinese.
Let's focus on movie descriptions.
In TMDB there are two language settings in the API:

  • zh labelled by TMDB as Mandarin that I mapped to Simplified Chinese (zh-cn)
  • cn labelled by TMDB as Cantonese that I mapped to Traditional Chinese (zh-tw)

Is this correct?
I interpret your previous comment as that it is not correct and it should be the opposite.

@courville
Copy link
Contributor

courville commented Aug 17, 2024

OK I think cn gets me only english which is wrong.
Though tmdb API tells me there is only cn (Cantonese) and zh (Mandarin) there is obviously more supported.
On tmdb interface I get zh-cn, zh-tw, zh-hk, zh-sg.
Could someone native tell me which I should use with which proper english translation (for now I have only two: Simplified Chinese and Traditional Chinese).

courville added a commit to nova-video-player/aos-Video that referenced this issue Aug 17, 2024
@courville
Copy link
Contributor

Please provide feedback on 6.2.92 and tell me if I need to add more Chinese language variants (with proper english naming translations).

@yu4nyu
Copy link

yu4nyu commented Aug 17, 2024

Propose to have the mapping as below:
zh-cn, Chinese (Mainland China)
zh-tw, Chinese (Taiwan)
zh-hk, Chinese (Hong Kong)

@courville
Copy link
Contributor

Thank you @yu4nyu, this makes better sense to me. Will do the changes.
On a separate topic regarding opensubtitles https://api.opensubtitles.com/api/v1/infos/languages, this is the mapping I propose:

  • zh-ca = Chinese (Cantonese) -> zh-hk Chinese (Hong Kong),
  • zh-cn = Chinese (simplified) -> zh-cn Chinese (Mainland China),
  • zh-tw = Chinese (traditional) -> zh-tw Chinese (Taiwan)
  • ze = Chinese bilingual -> ?

@courville
Copy link
Contributor

courville commented Aug 17, 2024

My final takeways.

  • basic Chinese howto for lost occidental nova coder
    • zh-cn Chinese (Mainland China): Mandarin (mostly in Simplified charset)
    • zh-tw Chinese (Taiwan): Min (mostly in Traditional charset)
    • zh-hk Chinese (Hong Kong): Cantonese
    • Character set = Simplified or Traditional
  • opensubtitles
    • zh-ca = Chinese (Cantonese) -> zh-hk Chinese (Hong Kong),
    • zh-cn = Chinese (simplified) -> zh-cn Chinese (Mainland China),
    • zh-tw = Chinese (traditional) -> zh-tw Chinese (Taiwan)
    • ze = Chinese bilingual -> Chinese Cantonese + English
  • tmdb (following Yu's proposal)
    • do not use zh Mandarin = zh-cn, Chinese (Mainland China)
    • do not use cn Cantonese = zh-hk, Chinese (Hong Kong)
    • add zh-tw, Chinese (Taiwan)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Important Bug severity
Projects
None yet
Development

No branches or pull requests

3 participants