feat: force auth for each transaction signature even if old not timed out #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
btw it's ready to merge if we want it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently storage unlocked on android for 5 min. I am forcing auth on UI for some cases like removing certificate, login auth or exporting secrets.
For signing transaction old version was requring pin only if auth times out.
Because user will need to scan qr code and pass result qr to camera back - it cannot happen accidentally I think.
I not sure if forcing auth each time will improve user experience but those are changes as discussed in security channel.
maybe @tetekinandrey have some thoughts.