Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BIP32/39/44 and Substrate (sr25519) Support #223

Closed
wants to merge 4 commits into from
Closed

BIP32/39/44 and Substrate (sr25519) Support #223

wants to merge 4 commits into from

Conversation

maciejhirsz
Copy link
Contributor

@maciejhirsz maciejhirsz commented Feb 20, 2019 •
edited
Loading

Rust

  • Remove dependency on parity-ethereum, use pure Rust crates when possible.
  • Handle BIP39 phrases.
  • Add BIP32 derivation with BIP44 paths.
  • Generate BIP39 phrases by default.
  • Attempt to derive with BIP32/44 first, fall back to parity derivation.
  • Separate functions for deriving BIP/Parity.
  • ...

React

  • ...

Issues

  • Creating new accounts is borked (cannot continue after entering name and selecting icon).
  • Fields for entering and displaying phrases are too small (BIP39 requires 24 words for good entropy).
  • Account recovery produces wrong keys? Are we doing previews in JS?
  • Not handling different networks in BIP44 yet!

@maciejhirsz maciejhirsz mentioned this pull request Mar 28, 2019
Merged
@maciejhirsz maciejhirsz mentioned this pull request Jun 7, 2019
Closed
6 tasks
@Tbaut Tbaut added the A1-onice label Jul 23, 2019
@maciejhirsz
Copy link
Contributor Author

Moving to a cleaner PR.

@maciejhirsz maciejhirsz deleted the mh-bip39-rs25519 branch July 23, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krodak krodak Awaiting requested review from krodak krodak will be requested when the pull request is marked ready for review krodak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejhirsz @Tbaut