Introduced new property 'url' in MQTTWebsocketTransport to accept custom url. #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcavar
reviewed
May 11, 2018
There was a problem hiding this comment.
Thanks @mendirattanishant. Added few comments.
Also, can we add some tests around this?
| /** url an NSString containing the websocketurl | ||
| * defaults to @"" | ||
| */ | ||
| @property (strong, nonatomic) NSString *url; |
There was a problem hiding this comment.
Why not NSURL and nil by default?
There was a problem hiding this comment.
Made the changes. Let me know if they look fine.
| @@ -34,8 +36,15 @@ - (instancetype)init { | |||
| - (void)open { | |||
| DDLogVerbose(@"[MQTTWebsocketTransport] open"); | |||
| self.state = MQTTTransportOpening; | |||
| NSMutableURLRequest *urlRequest = nil; | |||
There was a problem hiding this comment.
Instead of this, can we check:
if url == nil inside endpointURL and return it, otherwise do the same?
|
Great! Thank you @mendirattanishant. |
|
@jcavar should I update the readme? |
|
Would be nice, yes. |
This was referenced May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject
URLinMQTTWebsocketTransport.AWS IoT gives self signed URLs. Using the
urlproperty, user can set the url property directly instead of usingMQTTWebsocketTransportmethodendpointURLframing it for you using port, tls, etc.