fix(preferences): initialize state with user prefs check

novuhq · Sep 30, 2024 · fc8df8d · fc8df8d
1 parent bda2d7e
commit fc8df8d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/apps/web/src/pages/templates/editor_v2/CloudWorkflowSettingsSidePanel.tsx b/apps/web/src/pages/templates/editor_v2/CloudWorkflowSettingsSidePanel.tsx
@@ -16,10 +16,10 @@ export const CloudWorkflowSettingsSidePanel: FC<CloudWorkflowSettingsSidePanelPr
   const { templateId: workflowId = '' } = useParams<{ templateId: string }>();
   const [searchParams] = useSearchParams();
   const { isLoading, workflowUserPreferences, workflowResourcePreferences } = useCloudWorkflowPreferences(workflowId);
-  const { setValue } = useFormContext<WorkflowDetailFormContext>();
+  const { setValue, getValues } = useFormContext<WorkflowDetailFormContext>();
 
   useEffect(() => {
-    if (workflowUserPreferences !== undefined) {
+    if (workflowUserPreferences !== undefined && getValues('preferences') === undefined) {
       setValue('preferences', workflowUserPreferences, { shouldDirty: false });
     }
   }, [setValue, workflowUserPreferences]);

diff --git a/apps/web/src/studio/components/workflows/preferences/WorkflowSubscriptionPreferences.tsx b/apps/web/src/studio/components/workflows/preferences/WorkflowSubscriptionPreferences.tsx
@@ -47,7 +47,7 @@ export const WorkflowSubscriptionPreferences: FC<WorkflowSubscriptionPreferences
   updateWorkflowPreferences,
   arePreferencesDisabled,
 }) => {
-  const [isOverridingPreferences, setIsOverridingPreferences] = useState(false);
+  const [isOverridingPreferences, setIsOverridingPreferences] = useState(workflowUserPreferences !== null);
   // Use the user preferences if they exist, otherwise fall back to the resource preferences
   const [preferences, setPreferences] = useState<WorkflowPreferences>(
     workflowUserPreferences || workflowResourcePreferences!