fix(web): Use initial Workflow Preferences state to determine override state #6591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rifont
commented
Sep 30, 2024
|
|
||
| useEffect(() => { | ||
| if (workflowUserPreferences !== undefined) { | ||
| if (workflowUserPreferences !== undefined && getValues('preferences') === undefined) { |
There was a problem hiding this comment.
Using the form state to retain context of the form values, only setting the form values if it wasn't set already. This prevents the Preferences component state from being reset to null when the API fetch occurs on component render.
rifont
commented
Sep 30, 2024
| @@ -47,7 +47,7 @@ export const WorkflowSubscriptionPreferences: FC<WorkflowSubscriptionPreferences | |||
| updateWorkflowPreferences, | |||
| arePreferencesDisabled, | |||
| }) => { | |||
| const [isOverridingPreferences, setIsOverridingPreferences] = useState(false); | |||
| const [isOverridingPreferences, setIsOverridingPreferences] = useState(workflowUserPreferences !== null); | |||
There was a problem hiding this comment.
Fix to ensure the initial state for preference override toggle is correct to ensure the useEffect condition that resets the form value isn't fired on initial render.
…ot-saved-immediately
SokratisVidros
approved these changes
Sep 30, 2024
rifont
deleted the
nv-4322-workflow-preferences-are-lost-when-not-saved-immediately
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
https://www.loom.com/share/8b5aa3e3f8a749f48ff6b0d4425bb48d?sid=237293f4-746d-4cda-a46c-0350b62456db
Expand for optional sections
Related enterprise PR
Special notes for your reviewer