feat(js, react, shared): user agents #6626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
BiswaViraj
commented
Oct 4, 2024
| /** | ||
| * @internal Should be used internally | ||
| */ | ||
| __userAgent?: string; |
There was a problem hiding this comment.
couldn't find a better way to make it not expose to the public
Let me know if there's a better approach.
This __userAgent will appear in the autocomplete list if someone tries to initialise the Novu class from the @novu/js package:
const novu = new Novu()
There was a problem hiding this comment.
The only other alternative is not to add a property at all and add a ts ignore when you use it ;)
BiswaViraj
force-pushed
the
com-240-pass-parameters-to-initialize-session-analytics-for
branch
from
89578ce
to
6e6e9ae
Compare
novu
@novu/client
@novu/headless
@novu/framework
@novu/js
@novu/node
@novu/notification-center
@novu/providers
@novu/react
@novu/shared
commit: |
SokratisVidros
approved these changes
Oct 4, 2024
| /** | ||
| * @internal Should be used internally | ||
| */ | ||
| __userAgent?: string; |
There was a problem hiding this comment.
The only other alternative is not to add a property at all and add a ts ignore when you use it ;)
BiswaViraj
deleted the
com-240-pass-parameters-to-initialize-session-analytics-for
branch
tatarco
pushed a commit
that referenced
this pull request
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer