Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass input by ref #55

Closed
wants to merge 1 commit into from
Closed

Pass input by ref #55

wants to merge 1 commit into from

Conversation

Jake-Shadle
Copy link

to_string does not need to take the serialization input by value, changing it to pass by reference
aligns with how most other serde crates work.

Also adds a serde test that is an example of the use case that spurred this change.

Also adds a more "traditional" serde test that
is an example of the use case that spurred
this change.
@Arnavion
Copy link

The test will pass even without this change, because T: Serialize already implies &T: Serialize

@nox
Copy link
Owner

nox commented Jul 13, 2019

That's a breaking change, I'll keep it in mind next time I feel like doing a breaking bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants