Skip to content

Commit

Permalink
fix lint
Browse files Browse the repository at this point in the history
  • Loading branch information
olasaadi99 committed Oct 31, 2024
1 parent 0f5c386 commit f76f746
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
7 changes: 3 additions & 4 deletions pkg/common/strings.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
/*
Copyright 2023- IBM Inc. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0
*/

Expand All @@ -21,9 +22,8 @@ const (
NoConnections = "No Connections"
)
const (
spaceString = " "
protocolString = "protocol: "
// commaString = ", "
spaceString = " "
protocolString = "protocol: "
semicolonString = "; "
)

Expand Down Expand Up @@ -61,7 +61,6 @@ func getTCPUDPCubeStr(cube ds.Triple[*netset.ProtocolSet, *netset.PortSet, *nets
}

func getICMPCubeStr(cube ds.Pair[*netset.TypeSet, *netset.CodeSet]) string {
// tc := cube.ICMPTypeCode()
if cube.Left.Equal(netset.AllICMPTypes()) && cube.Right.Equal(netset.AllICMPCodes()) {
return ""
}
Expand Down
3 changes: 2 additions & 1 deletion pkg/commonvpc/sg_analysis.go
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,8 @@ func (sga *SGAnalyzer) allowedConnectivity(target, local *netset.IPBlock, isIngr
// 2. If connection is part of the query: is the required connection contained in the existing connection?
// if it does, then the contributing rules are detected: rules that intersect the required connection
// otherwise, the answer to the query is "no" and nil is returned
func (sga *SGAnalyzer) rulesFilterInConnectivity(target, local *netset.IPBlock, connQuery *netset.TransportSet, isIngress bool) ([]int, error) {
func (sga *SGAnalyzer) rulesFilterInConnectivity(target, local *netset.IPBlock,
connQuery *netset.TransportSet, isIngress bool) ([]int, error) {
analyzedConnsMap := sga.ingressOrEgressConnectivity(isIngress)
for definedLocal, analyzedConns := range analyzedConnsMap {
if local.IsSubset(definedLocal) {
Expand Down

0 comments on commit f76f746

Please sign in to comment.