Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

non-consistent dump in ibmvpc test TestAllWithComparison/iks_workers_large#05 (commented) #847

Closed
ShiriMoran opened this issue Sep 3, 2024 · 3 comments
Closed

non-consistent dump in ibmvpc test TestAllWithComparison/iks_workers_large#05 (commented) #847

ShiriMoran opened this issue Sep 3, 2024 · 3 comments
Assignees
@haim-kermany
Labels
bug Something isn't working drawio High prio High priority issues tests
Milestone
v0.7

Comments

@ShiriMoran
Copy link
Contributor

ShiriMoran commented Sep 3, 2024 •
edited
Loading

The dump seems in drawio area and is not consistent
https://github.com/np-guard/vpc-network-config-analyzer/actions/runs/10668928052/job/29569713712?pr=843


panic: runtime error: integer divide by zero [recovered]
	panic: runtime error: integer divide by zero

goroutine 85 [running]:
testing.tRunner.func1.2({0xa2f540, 0x1020dc0})
	/opt/hostedtoolcache/go/1.22.4/x64/src/testing/testing.go:1631 +0x24a
testing.tRunner.func1()
	/opt/hostedtoolcache/go/1.22.4/x64/src/testing/testing.go:1634 +0x377
panic({0xa2f540?, 0x1020dc0?})
	/opt/hostedtoolcache/go/1.22.4/x64/src/runtime/panic.go:770 +0x132
github.com/np-guard/vpc-network-config-analyzer/pkg/drawio.(*layoutOverlap).potentialBypassPoints(0xc0148abd10, {0x60f7be?, 0x60539b?}, {0xacaf20?, 0xc00003f750?}, {0x623cad?, 0xc03e6469c0?})
	/home/runner/work/vpc-network-config-analyzer/vpc-network-config-analyzer/pkg/drawio/layoutOverlap.go:195 +0x554
github.com/np-guard/vpc-network-config-analyzer/pkg/drawio.(*layoutOverlap).getBypassPoint(0xc0148abd10, {0xc03e6469c0?, 0x0?}, {0x4d?, 0x3e00618800020403?}, {0xc110e0?, 0xc03e63cb40?}, {0xc110e0, 0xc03e63cb40})
	/home/runner/work/vpc-network-config-analyzer/vpc-network-config-analyzer/pkg/drawio/layoutOverlap.go:216 +0x4b
github.com/np-guard/vpc-network-config-analyzer/pkg/drawio.(*layoutOverlap).handleLinesOverIcons(0xc0148abd10)
	/home/runner/work/vpc-network-config-analyzer/vpc-network-config-analyzer/pkg/drawio/layoutOverlap.go:166 +0x36d
github.com/np-guard/vpc-network-config-analyzer/pkg/drawio.(*layoutOverlap).fixOverlapping(0xc0148abd10)
	/home/runner/work/vpc-network-config-analyzer/vpc-network-config-analyzer/pkg/drawio/layoutOverlap.go:72 +0x39
github.com/np-guard/vpc-network-config-analyzer/pkg/drawio.(*layoutS).layout(0xc00003faa0)
	/home/runner/work/vpc-network-config-analyzer/vpc-network-config-analyzer/pkg/drawio/layout.go:103 +0x6db
@ShiriMoran ShiriMoran mentioned this issue Sep 3, 2024
Merged
@ShiriMoran
Copy link
Contributor Author

ShiriMoran commented Sep 4, 2024 •
edited
Loading

also here https://github.com/np-guard/vpc-network-config-analyzer/actions/runs/10697602099/job/29655141446?pr=843
and here https://github.com/np-guard/vpc-network-config-analyzer/actions/runs/10701216978/job/29666687473?pr=854
and here https://github.com/np-guard/vpc-network-config-analyzer/actions/runs/10714103129/job/29707238950?pr=854

Please consider prioritizing @zivnevo @haim-kermany

@zivnevo zivnevo added the tests label Sep 4, 2024
@zivnevo zivnevo added this to the v0.7 milestone Sep 4, 2024
ShiriMoran added a commit that referenced this issue Sep 5, 2024
@ShiriMoran
commented until #847 is fixed
ffcbaba
@ShiriMoran ShiriMoran changed the title non-consistent dump in git push-tests non-consistent dump in ibmvpc test TestAllWithComparison/iks_workers_large#05 (commented) Sep 5, 2024
ShiriMoran added a commit that referenced this issue Sep 5, 2024
@ShiriMoran
commented until #847 is fixed
586b6ec
@zivnevo zivnevo added the High prio High priority issues label Sep 26, 2024
@zivnevo zivnevo mentioned this issue Sep 26, 2024
Closed
@zivnevo zivnevo added bug Something isn't working drawio labels Sep 26, 2024
@zivnevo
Copy link
Member

zivnevo commented Oct 31, 2024

@haim-kermany can this issue be closed too?

@zivnevo
Copy link
Member

zivnevo commented Nov 6, 2024

Fixed by #900

@zivnevo zivnevo closed this as completed Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haim-kermany haim-kermany

Labels
bug Something isn't working drawio High prio High priority issues tests
Projects
None yet
Milestone
v0.7
Development

No branches or pull requests
3 participants
@zivnevo @haim-kermany @ShiriMoran