Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

765 test seperation #875

Merged
merged 37 commits into from
Sep 25, 2024
Merged

765 test seperation #875

merged 37 commits into from
Sep 25, 2024

Conversation

ShiriMoran
Copy link
Contributor

No description provided.

@ShiriMoran ShiriMoran marked this pull request as draft September 17, 2024 06:40
@ShiriMoran ShiriMoran marked this pull request as ready for review September 17, 2024 11:19
@ShiriMoran
Copy link
Contributor Author

fixes #765

@ShiriMoran ShiriMoran linked an issue Sep 18, 2024 that may be closed by this pull request
Refactor testcase so that there is a basic struct and seperate struct for each report, diff, explain and lint #765
Closed
zivnevo
zivnevo requested changes Sep 23, 2024
View reviewed changes
pkg/ibmvpc/explainability_test.go Outdated Show resolved Hide resolved
pkg/awsvpc/explainability_test.go Outdated Show resolved Hide resolved
pkg/ibmvpc/diff_test.go Outdated Show resolved Hide resolved
pkg/commonvpc/semantic_diff_test_functionality.go Outdated Show resolved Hide resolved
pkg/commonvpc/common_test_functionality.go Outdated Show resolved Hide resolved
pkg/commonvpc/semantic_diff_test_functionality.go Outdated Show resolved Hide resolved
pkg/commonvpc/lint_test_functionality.go Outdated Show resolved Hide resolved
pkg/commonvpc/common_test_functionality.go Outdated Show resolved Hide resolved
pkg/commonvpc/common_test_functionality.go Outdated Show resolved Hide resolved
This was referenced Sep 23, 2024
Closed
Open
@ShiriMoran ShiriMoran marked this pull request as draft September 24, 2024 05:31
@ShiriMoran ShiriMoran marked this pull request as ready for review September 24, 2024 08:04
@ShiriMoran ShiriMoran linked an issue Sep 24, 2024 that may be closed by this pull request
have a dedicated package for test functionality #885
Closed
@ShiriMoran ShiriMoran merged commit 6be16d5 into main Sep 25, 2024
4 checks passed
@ShiriMoran ShiriMoran deleted the 765_test_seperation branch September 25, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zivnevo zivnevo zivnevo approved these changes

Assignees
No one assigned
Labels
size/XXL
Projects
None yet
Milestone
No milestone
2 participants
@ShiriMoran @zivnevo