feat: add clone_url to config.toml
#516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npalm
approved these changes
Jul 16, 2022
|
🎉 This PR is included in version 5.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
Using this method has an issue with ssl certificates that don't have the clone url. Is there a way to have the dns resolve to a different ip address instead? I have tried to append records to the hosts file, but it only does in the container and not the runner machine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the missing parameter
clone_urlto theconfig.tomlof the runner. In case the default clone URL from the GitLab project is not accessible from the runner's infrastructure (e.g. private DNS), theclone_urlcan be used to specify a different one (e.g. replace the private DNS entry by a public IP address).Check the configuration docs for the runner.
Migrations required
No.
Verification
clone_url. Check that the runner can register andconfig.tomlshows an emptyclone_url. Ensure that jobs are still processed as we didn't have aclone_urlin the config before.clone_url. Check that the runner can register andconfig.tomlshows the mentionedclone_url.I check this within the Hapag-Lloyd GitLab Runner infrastructure.