fix: properly differentiate http and https proxies #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this would also solve #87. |
options.secureEndpoint is not always defined. There is however, a function to properly identify the type of connection in the base class, so intead of rolling the own check, relly on the base class implementation. Fixes npm#87 and npm/cli#7024 Contributed by STMicroelectronics Signed-off-by: Torbjörn SVENSSON <[email protected]>
Torbjorn-Svensson
force-pushed
the
pr/fix-http-https-proxy-selection
branch
from
aa90a00
to
eae4b1c
Compare
|
@wraithgar: Can you review this again? I fixed the lint issue (not sure why I didn't see that before). |
wraithgar
changed the title
wraithgar
changed the title
|
@wraithgar: Do you need me to do something or can you take it from here? |
lukekarrys
approved these changes
Feb 1, 2024
|
@Torbjorn-Svensson Thank you! This looks good and @wraithgar and I can take it from here. We'll get this merged once we get our CI sorted and then land it in the CLI in time for the next release. |
Merged
wraithgar
pushed a commit
that referenced
this pull request
Feb 5, 2024
🤖 I have created a release *beep* *boop* --- ## [2.2.1](v2.2.0...v2.2.1) (2024-02-01) ### Bug Fixes * [`88212cc`](88212cc) [#92](#92) properly differentiate http and https proxies (#92) (@Torbjorn-Svensson) ### Chores * [`9ffc694`](9ffc694) [#90](#90) postinstall for dependabot template-oss PR (@lukekarrys) * [`7243097`](7243097) [#90](#90) bump @npmcli/template-oss from 4.21.1 to 4.21.3 (@dependabot[bot]) * [`ee9ea76`](ee9ea76) [#88](#88) postinstall for dependabot template-oss PR (@lukekarrys) * [`e169c95`](e169c95) [#88](#88) bump @npmcli/template-oss from 4.19.0 to 4.21.1 (@dependabot[bot]) * [`cfdcf70`](cfdcf70) [#73](#73) move proxy:null to correct test (@lukekarrys) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
options.secureEndpoint is not always defined. There is however, a function to properly identify the type of connection in the base class, so intead of rolling the own check, relly on the base class implementation.
Fixes npm/cli#7024
Contributed by STMicroelectronics
References