This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix(shrinkwrap): always set name on the root node, closes npm/cli#2264 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
added a commit
to npm/cli
that referenced
this pull request
Aug 12, 2021
Name is always now set on the root node See: npm/arborist#310
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is maybe less than ideal because it means everyone who has their project in a directory with the same name as the project is going to see this field being added. it's a one time change though, which feels a lot more acceptable than the current behavior of adding and removing the name field based on the directory name since that can create a lot of churn in a team for no good reason
References
Closes npm/cli#2264