feat: fixBin accept exec mode as optional parameter #29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some bin js file is using CRLF, and they cannot work with yarn/npminstall, but they can work with npm, due to
fixBin
would try to fix.So if this package exports
isWindowsHashbangFile
anddos2Unix
, we can pr to yarn/npminstall to reuse the logic removing windows line-endings on the hashbang line.And about not just using the
fixBin
directly, becauseyarn/npminstall/pnpm
doesnot set the same chmod here, they set 0o755, but bin-links set 0o777.References
Some issues from those packages: