Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixBin accept exec mode as optional parameter #29

Merged
merged 1 commit into from
Oct 14, 2021
Merged

feat: fixBin accept exec mode as optional parameter #29

merged 1 commit into from
Oct 14, 2021

Conversation

vagusX
Copy link
Contributor

@vagusX vagusX commented Oct 13, 2021

There are some bin js file is using CRLF, and they cannot work with yarn/npminstall, but they can work with npm, due to fixBin would try to fix.

So if this package exports isWindowsHashbangFile and dos2Unix, we can pr to yarn/npminstall to reuse the logic removing windows line-endings on the hashbang line.

And about not just using the fixBin directly, because yarn/npminstall/pnpm doesnot set the same chmod here, they set 0o755, but bin-links set 0o777.

References

Some issues from those packages:

@vagusX vagusX marked this pull request as ready for review October 13, 2021 02:18
@wraithgar
Copy link
Member

Perhaps a more robust fix would be to allow you to set the permissions fix-bin uses, so that you can start using it?

@vagusX
Copy link
Contributor Author

vagusX commented Oct 14, 2021

@wraithgar got it, updated

@vagusX vagusX changed the title feat: export dos2Unix and isWindowsHashbangFile in lib/fix-bin feat: fixBin accept exec mode as optional parameter Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants