Skip to content

Commit

Permalink
use sh as default unix shell, not bash
Browse files Browse the repository at this point in the history
PR-URL: #2067
Credit: @isaacs
Close: #2067
Reviewed-by: @nlf
  • Loading branch information
isaacs authored and ruyadorno committed Oct 30, 2020
1 parent d4119b0 commit 3990b42
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/utils/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const editor = process.env.EDITOR ||
(isWindows ? 'notepad.exe' : 'vi')

const shell = isWindows ? process.env.ComSpec || 'cmd'
: process.env.SHELL || 'bash'
: process.env.SHELL || 'sh'

const { tmpdir, networkInterfaces } = require('os')
const getLocalAddresses = () => {
Expand Down
2 changes: 1 addition & 1 deletion test/lib/utils/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ t.test('no shell on posix', t => {
'@npmcli/ci-detect': () => false,
'../../../lib/utils/is-windows.js': false
})
t.equal(config.defaults.shell, 'bash')
t.equal(config.defaults.shell, 'sh')
t.end()
})

Expand Down

0 comments on commit 3990b42

Please sign in to comment.