Skip to content

Commit

Permalink
test: fix git configs for git 2.23 and above
Browse files Browse the repository at this point in the history
Config values are now case-sensitive, so `commit.gpgsign=false` was
doing nothing.

PR-URL: #456
Credit: @isaacs
Close: #456
Reviewed-by: @claudiahdz
  • Loading branch information
isaacs authored and claudiahdz committed Nov 14, 2019
1 parent 5c3b327 commit 454c7dd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/common-tap.js
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,8 @@ exports.makeGitRepo = function (params, cb) {
git.chainableExec(['config', 'user.name', user], opts),
git.chainableExec(['config', 'user.email', email], opts),
// don't time out tests waiting for a gpg passphrase or 2fa
git.chainableExec(['config', 'commit.gpgsign', 'false'], opts),
git.chainableExec(['config', 'commit.gpgSign', 'false'], opts),
git.chainableExec(['config', 'tag.gpgSign', 'false'], opts),
git.chainableExec(['config', 'tag.forceSignAnnotated', 'false'], opts),
git.chainableExec(['add'].concat(added), opts),
git.chainableExec(['commit', '-m', message], opts)
Expand Down

0 comments on commit 454c7dd

Please sign in to comment.