Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: [email protected] #1544

Closed
wants to merge 1 commit into from
Closed

deps: [email protected] #1544

wants to merge 1 commit into from

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Jul 21, 2020 •
edited
Loading

Bump the version of meant

Updates:

  • Bump dev deps versions
  • Replace travis with GitHub Actions

Refs: https://github.com/watilde/meant/blob/master/CHANGELOG.md#102-2020-07-19

@watilde watilde requested a review from a team as a code owner July 21, 2020 02:12
@ljharb
Copy link
Contributor

ljharb commented Jul 21, 2020

replacing Travis is a massive change that both should happen in its own commit, and its own pr

@watilde
Copy link
Contributor Author

watilde commented Jul 21, 2020

@ljharb Yes, and it is separated in the dependency's repository. Did you mean it should be major update in terms of semver? I can bump major version in that case.

@ljharb
Copy link
Contributor

ljharb commented Jul 21, 2020

@watilde sorry, what i meant is, updating "how CI works" in this repo is something that deserves its own PR. Updating meant is a small change that shouldn't be conflated with changing this repo's CI setup.

@watilde
Copy link
Contributor Author

watilde commented Jul 21, 2020

@ljharb Got it! Thank you for your clear explanation and review<3

@ruyadorno ruyadorno added Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes labels Aug 14, 2020
ruyadorno added a commit that referenced this pull request Aug 17, 2020
@ruyadorno
[email protected]
a6e9fc4 
PR-URL: #1544
Credit: @watilde
Close: #1544
Reviewed-by: @ruyadorno
@ruyadorno ruyadorno closed this in 620b0ff Aug 17, 2020
@watilde watilde deleted the patch/meant branch August 19, 2020 09:59
@snyk-bot snyk-bot mentioned this pull request Sep 15, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
Release 6.x work is associated with a specific npm 6 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@watilde @ljharb @ruyadorno