-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Security Pipeline #1586
Conversation
Thank you npm CLI team for giving us the opportunity to speak today, this was an eye-opening experience on how contributing to FOSS works, and this helped break the ice for us moving forward if we decide to contribute more in the future. |
1fe6f0c
to
34a591c
Compare
464daf0
to
34a591c
Compare
62bbfb9
to
f4e7a07
Compare
63d242d
to
288f210
Compare
288f210
to
ca3b53a
Compare
Hey npm team, just wondering if there's any status updates regarding this PR? |
Re-added Comments & Step Names
Add comments and correct npm step names
ca3b53a
to
6356b38
Compare
@jskoll appreciate the work you & your team did. We're going to go through our own automation overhaul in the near future which will include Actions dedicated to security/vulnerability gates that are different than the tooling you've presented here. Again, want to thank you very much for considering how we can improve the safety/security of |
This PR is being created as part of a class (SENG 540) at WVU (West Virginia University). The class was about software evolution. The group I was in decided to look at the evolution of DevOps into DevSecOps. This PR adds some security related steps into the pipeline.
The PR adds a new GitHub action called Security Checks that:
ubuntu-latest
npm install
npm audit
against production packages with the audit level set at moderatenpm audit
against the entire package with the audit level set at criticaltwly
to look for duplicated code.This pipeline is setup this way to avoid any known security issue above moderate from being used within the production builds of npm and to give more visibility of security issues within dev-dependencies.
twly itself is not necessarily a security tool but the idea of having it included is to help keep the npm code DRY (Don't Repeat Yourself). This will help security overall by ensuring that any bug/security issue found in the code will only need to be fixed in less spots (hopefully just one). This tool is configurable through the
.trc
file and is currently setup to fail at anything below a threshold of 95. As configured it will only look thesrc
folder and report duplicates if a minimum of 5 lines and 50 characters are found duplicated.Also in this PR is a dependabot config file. This is in here to help maintain up-to-date dependencies, it is configured to run once a week.
This PR was the work of: