-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Do not send user secret in the referer header #1663
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
darcyclarke
previously requested changes
Aug 12, 2020
ruyadorno
approved these changes
Aug 14, 2020
ruyadorno
added
Enhancement
new feature or improvement
Release 6.x
work is associated with a specific npm 6 release
semver:patch
semver patch level for changes
labels
Aug 14, 2020
ruyadorno
pushed a commit
that referenced
this pull request
Aug 17, 2020
PR-URL: #1663 Credit: @assapir Close: #1663 Reviewed-by: @ruyadorno
ruyadorno
pushed a commit
that referenced
this pull request
Aug 17, 2020
PR-URL: #1663 Credit: @assapir Close: #1663 Reviewed-by: @ruyadorno
This was referenced Mar 12, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Enhancement
new feature or improvement
Release 6.x
work is associated with a specific npm 6 release
semver:patch
semver patch level for changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, CLI is sending the command line args in the referer header, which might be logged.