test: add outdated tests #1750
Closed
test: add outdated tests #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Aug 31, 2020
claudiahdz
force-pushed
the
test/v7-outdated
branch
8 times, most recently
from
fdbc5aa
to
13f72d8
Compare
claudiahdz
force-pushed
the
test/v7-outdated
branch
from
13f72d8
to
bcce693
Compare
|
Some snapshots are failing on Windows when |
darcyclarke
added
Release 7.x
ruyadorno
pushed a commit
that referenced
this pull request
Sep 16, 2020
PR-URL: #1750 Credit: @claudiahdz Close: #1750 Reviewed-by: @ruyadorno
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds tests to npm outdated. While working on it I found some bugs:
--globalwasn't working since the global directory doesn't behave like a normal package and there are noedgesOutcoming out of it. Instead, I'm using the children property to iterate over the different globally installed packages.Setand therefore no package in there gets ever duplicated. Memoizing doesn't make sense if we won't ever fetch the packument of a package twice. Concern: Are there cases when we need the duplication?--all?