Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added count on reify-output #1858

Closed
wants to merge 1 commit into from
Closed

fix: added count on reify-output #1858

wants to merge 1 commit into from

Commits on Sep 25, 2020

  1. fix: added count on reify-output 

    The added count on lib/utils/reify-output.js only looks up resulting
keys from arb.diff and does not take into account the fact that some of
these pkgs signaled as diff=ADD might in fact not have been installed,
most common scenario are optional deps that could have failed their
install in a given system or opt-out from configs.

This fixes the counting number by looking up at arb.inventory and
confirming it has the node that has been marked as added on diff result.

Fix: npm#1813
    @ruyadorno
    ruyadorno committed Sep 25, 2020
    Configuration menu
    Copy the full SHA
    06d64dc View commit details
    Browse the repository at this point in the history