Revert "Remove unused npx binary" #1903
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f019a24. Git Bash on Windows still uses this file. Removing it broke the windows MSI builds in Node.js infrastructure. Unless we absolutely need to remove this I think it is worth keeping around
darcyclarke
added
Release 7.x
isaacs
pushed a commit
that referenced
this pull request
Oct 6, 2020
This reverts commit f019a24. Git Bash on Windows still uses this file. Removing it broke the windows MSI builds in Node.js infrastructure. Unless we absolutely need to remove this I think it is worth keeping around PR-URL: #1903 Credit: @MylesBorins Close: #1903 Reviewed-by: @isaacs
|
we should also fix the permission of this file! which was the original intent of #1792 |
|
@ruyadorno I've floated your patch |
|
we just merged it 😊 it's out in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f019a24.
Git Bash on Windows still uses this file. Removing it broke
the windows MSI builds in Node.js infrastructure. Unless we
absolutely need to remove this I think it is worth keeping
around