fix npx for non-interactive shells #1936
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
added
the
Release 7.x
ruyadorno
pushed a commit
that referenced
this pull request
Oct 9, 2020
PR-URL: #1936 Credit: @nlf Close: #1936 Reviewed-by: @ruyadorno
|
landed in e859fba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
npx(andnpm exec) will fail with acb() never callederror when run in a non-interactive way and not providing an explicit-ydue to the prompt. These changes make it so that instead of prompting in non-interactive shells, we log a warning and then continue as though the user answered yes to the prompt making things behave much more like npm 6