Fix git repository discovery in npm version

[reegnz]

When package.json is not in the git root, then npm version bumps didn't
make a commit.

Issue was with how npm version discovered if it's in a git repository: it
assumed that it's a git repository only if .git folder is at the same
level as the package.json.

In reality you cannot make such assumptions, as the .git directory is
implementation detail.

Proper way of discovering if you're in a git directory is invoking
git rev-parse --git-dir.

[reegnz]

I also opened a thread about it here , but found out that it's an easy fix, so I did the change instead. :)

[isaacs]

Can you update the test as well? They're failing: https://travis-ci.com/npm/cli/jobs/219563951#L1661

These look directly related to changes to lib/version.js. Is the behavior change intentional?

[reegnz]

@isaacs it wasn't intentional, will try to figure out why those tests fail.

[zerog2k]

I understand there is an argument against doing git tag if this is a package in a subdir of a repo with other packages (with potentially separate versioning -- although here, I would expect users to explicitly disable git tagging?). So if this doesn't get merged, I +1 @reegnz idea to emit warning and/or update npm help version with note about not git tagging in subdirs.

[ljharb]

@zerog2k you can customize the tag prefix in each subdir with .npmrc, and then npm version in the subdir will produce the right tag.

[ivos]

Pardon my ignorance, but I don't understand what is the resolution of this issue. Is is (going to be) merged in? In what version of npm should I expect it to land?

There's a label Release 6.x assigned, but although my npm --version says 7.6.3, it still does not seem to be fixed.

[4-life]

@ivos doesn't merged. Original issue is still not resolved npm/npm#9111