ci: run install scripts for root project #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
approved these changes
Dec 9, 2020
XhmikosR
reviewed
Dec 9, 2020
| 'preinstall', | ||
| 'install', | ||
| 'postinstall', | ||
| 'prepublish', // XXX should we remove this finally?? |
There was a problem hiding this comment.
Just wondering, I thought prepublish was deprecated?
There was a problem hiding this comment.
please don't remove it yet :-) imo the churn isn't worth it. it'd be better to remove prepublishOnly and make prepublish, only running on prepublish, the actual behavior.
There was a problem hiding this comment.
I think since we already shipped v7, we have this on the agenda for npm v8. It's a breaking change if we remove it, and at least an annoying change (if not actually breaking) if we deprecate it with a warning.
- remove (or deprecate with a warning)
prepublishon install/ci - remove (or deprecate with a warning)
prepublishOnly
There was a problem hiding this comment.
Given that’s the plan, I’d prefer the former :-D (which, iirc, was the original planned end state)
ruyadorno
added
Release 7.x
`npm ci` should run all the same preinstall/install/postinstall/prepare scripts for the root project just like `npm install`. Fixes: #1905 PR-URL: #2316 Credit: @isaacs Close: #2316 Reviewed-by: @ruyadorno
darcyclarke
approved these changes
Dec 11, 2020
isaacs
force-pushed
the
isaacs/ci-scripts
branch
from
33859cc
to
d825e90
Compare
Merged
This was referenced Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm cishould run all the same preinstall/install/postinstall/preparescripts for the root project just like
npm install.Fixes: #1905
References