Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better explanation on OTP #24

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

jdeniau
Copy link
Contributor

@jdeniau jdeniau commented Jul 20, 2018

Re-import of npm/npm#21119

Use the defaut OTP explanation everywhere except when the context is "OTP-aware" (like when setting double-authentication).

@zkat I followed your recommendation about npm login, I just changed the message a little to be more understandable than the previous one, but not as verbose as the default one ;)

@jdeniau jdeniau requested a review from a team as a code owner July 20, 2018 19:52
Use the defaut OTP explanation everywhere except when the context is
"OTP-aware" (like when setting double-authentication)
@jdeniau jdeniau force-pushed the otp-explanation-on-more-endpoints branch from 1a00846 to 7a3629b Compare July 20, 2018 19:54
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for recreating the PR. This looks great, and the rewording is 💯!

LGTM 👍

@zkat zkat changed the base branch from latest to release-next July 20, 2018 22:03
@zkat zkat merged commit 21cf0ab into npm:release-next Jul 20, 2018
@jdeniau jdeniau deleted the otp-explanation-on-more-endpoints branch July 21, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants