-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add run-script workspaces #2864
Merged
ruyadorno
merged 1 commit into
npm:release-next
from
ruyadorno:add-run-script-workspaces
Mar 18, 2021
Merged
feat: add run-script workspaces #2864
ruyadorno
merged 1 commit into
npm:release-next
from
ruyadorno:add-run-script-workspaces
Mar 18, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
force-pushed
the
add-run-script-workspaces
branch
from
March 15, 2021 04:48
7f60959
to
28d5c7e
Compare
ruyadorno
added
Release 7.x
work is associated with a specific npm 7 release
release: next
These items should be addressed in the next release
semver:minor
new backwards-compatible feature
labels
Mar 15, 2021
ruyadorno
force-pushed
the
add-run-script-workspaces
branch
from
March 15, 2021 04:49
28d5c7e
to
dfbdbb9
Compare
ruyadorno
added
the
pr: needs documentation
pull request requires docs before merging
label
Mar 15, 2021
ruyadorno
force-pushed
the
add-run-script-workspaces
branch
from
March 15, 2021 05:08
dfbdbb9
to
89e879f
Compare
wraithgar
reviewed
Mar 15, 2021
wraithgar
reviewed
Mar 15, 2021
wraithgar
reviewed
Mar 15, 2021
wraithgar
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this even with the feedback in case we want to say "yeah we can refine this later" cause it works and is pretty darn good and we have lots of work to go in workspaces.
ruyadorno
force-pushed
the
add-run-script-workspaces
branch
from
March 15, 2021 15:02
89e879f
to
ec9f675
Compare
ruyadorno
removed
the
pr: needs documentation
pull request requires docs before merging
label
Mar 15, 2021
Updated with docs 😄 |
ruyadorno
force-pushed
the
add-run-script-workspaces
branch
from
March 16, 2021 16:15
c4c9e6c
to
96552a0
Compare
- Add workspaces-related configs: - workspace: list of workspaces names/dir to filter for - workspaces: boolean value to enable/disable workspaces awareness - adds the proposed note in the docs of each of the commands that are not affected by these configs. - Add workspaces support to `npm run-script` - add ability to serially run lifecycle scripts in workspaces - add ability to list scripts for all workspaces - add colors to `npm run` (no args) output Relates to: npm/rfcs#117 Fixes: npm/statusboard#276 Fixes: npm/statusboard#283 Fixes: npm/statusboard#284 Fixes: npm/statusboard#285 Fixes: npm/statusboard#286 PR-URL: npm#2864 Credit: @ruyadorno Close: npm#2864 Reviewed-by: @wraithgar
ruyadorno
force-pushed
the
add-run-script-workspaces
branch
from
March 18, 2021 22:14
96552a0
to
335cbc3
Compare
ruyadorno
added a commit
that referenced
this pull request
Mar 18, 2021
- Add workspaces-related configs: - workspace: list of workspaces names/dir to filter for - workspaces: boolean value to enable/disable workspaces awareness - adds the proposed note in the docs of each of the commands that are not affected by these configs. - Add workspaces support to `npm run-script` - add ability to serially run lifecycle scripts in workspaces - add ability to list scripts for all workspaces - add colors to `npm run` (no args) output Relates to: npm/rfcs#117 Fixes: npm/statusboard#276 Fixes: npm/statusboard#283 Fixes: npm/statusboard#284 Fixes: npm/statusboard#285 Fixes: npm/statusboard#286 PR-URL: #2864 Credit: @ruyadorno Close: #2864 Reviewed-by: @wraithgar
This was referenced Mar 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
release: next
These items should be addressed in the next release
Release 7.x
work is associated with a specific npm 7 release
semver:minor
new backwards-compatible feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that are not affected by these configs.
npm run-script
npm run
(no args) outputReferences
Relates to: npm/rfcs#117
Fixes: npm/statusboard#276
Fixes: npm/statusboard#283
Fixes: npm/statusboard#284
Fixes: npm/statusboard#285
Fixes: npm/statusboard#286
Fixes: npm/statusboard#269