Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(errorHandler): rename to exit handler #3416

Merged
merged 1 commit into from
Jun 23, 2021
Merged

chore(errorHandler): rename to exit handler #3416

merged 1 commit into from
Jun 23, 2021

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Jun 15, 2021 •
edited
Loading

Code cleanup here too. No functionality was changed, but tests were tweaked to account for the lessened surface area.

NOTE: this changes our infamous cb() never called error to reflect reality a little more closely.

@wraithgar wraithgar requested a review from a team as a code owner June 15, 2021 16:02
@darcyclarke darcyclarke added Release 7.x work is associated with a specific npm 7 release release: next These items should be addressed in the next release semver:patch semver patch level for changes labels Jun 16, 2021
nlf
nlf approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! as far as i can see there is no functionality change and the code is much easier to comprehend quickly. the renaming is also incredibly fitting since the handler is called every time we exit, not just for errors.

@wraithgar
chore(errorHandler): rename to exit handler
54eae30 
Cleaned the code up too

PR-URL: #3416
Credit: @wraithgar
Close: #3416
Reviewed-by: @nlf
@wraithgar wraithgar merged commit 54eae30 into release-next Jun 23, 2021
@wraithgar wraithgar deleted the gar/exit-handler branch June 23, 2021 16:53
@wraithgar wraithgar mentioned this pull request Jun 23, 2021
Closed
@npm npm deleted a comment Jun 23, 2021
@npm npm locked as spam and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
release: next These items should be addressed in the next release Release 7.x work is associated with a specific npm 7 release semver:patch semver patch level for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wraithgar @nlf @darcyclarke