Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(benchmarks): tidy up benchmark workflows #4145

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Dec 9, 2021

drops some variables we don't consume anywhere, makes the event name something useful in the benchmarks repo, and updates the accept headers off of the old preview type

References

@nlf nlf requested a review from a team as a code owner December 9, 2021 00:04
@npm-robot
Copy link
Contributor

npm-robot commented Dec 9, 2021

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 45.351 ±3.00 26.656 ±0.23 15.929 ±0.06 18.469 ±1.01 2.695 ±0.01 2.685 ±0.00 2.188 ±0.05 10.601 ±0.07 2.145 ±0.00 2.870 ±0.02
#4145 43.824 ±0.34 27.148 ±0.00 16.054 ±0.11 18.715 ±1.29 2.720 ±0.01 2.736 ±0.00 2.199 ±0.08 10.691 ±0.05 2.160 ±0.01 3.116 ±0.32
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.294 ±0.05 21.061 ±0.18 11.760 ±0.04 13.076 ±0.04 2.420 ±0.03 2.425 ±0.02 2.169 ±0.02 7.871 ±0.12 2.027 ±0.00 2.541 ±0.02
#4145 36.491 ±0.24 21.265 ±0.05 12.044 ±0.14 13.064 ±0.19 2.459 ±0.00 2.462 ±0.02 2.190 ±0.01 8.030 ±0.03 2.048 ±0.01 2.614 ±0.10

@nlf nlf force-pushed the nlf/benchmark-workflow-tweaks branch from 406c4c5 to 6b80faa Compare December 9, 2021 18:09
@nlf nlf merged commit 6b80faa into release-next Dec 9, 2021
@nlf nlf deleted the nlf/benchmark-workflow-tweaks branch December 9, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants