Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(arborist): add named updates validation #4307

Merged

Conversation

ruyadorno
Copy link
Contributor

@ruyadorno ruyadorno commented Jan 21, 2022

Arborist update does not support anything other than dependency names,
that is confusing to some users that are used to provide semver ranges
when using npm install and other commands.

This changeset adds validation to the values provided as arguments in
npm update and will throw a EUPDATEARGS error in case the user tries
to use semver ranges, e.g: npm update [email protected]

References

Relates to: #4240

Arborist update does not support anything other than dependency names,
that is confusing to some users that are used to provide semver ranges
when using `npm install` and other commands.

This changeset adds validation to the values provided as arguments in
`npm update` and will throw a `EUPDATEARGS` error in case the user tries
to use semver ranges, e.g: `npm update [email protected]`

Relates to: npm#4240
@ruyadorno ruyadorno requested a review from a team as a code owner January 21, 2022 20:00
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with a small note about possibly changing the error message.

@ruyadorno
Copy link
Contributor Author

ok, pushed that error message change 😊

@ruyadorno ruyadorno merged commit fbe48a8 into npm:release-next Jan 26, 2022
@wraithgar wraithgar mentioned this pull request Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants