Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(arborist): refactor arborist bin to use consistent timing/logging #4452

Merged
merged 1 commit into from
Feb 24, 2022
Merged

feat(arborist): refactor arborist bin to use consistent timing/logging #4452

merged 1 commit into from
Feb 24, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Feb 22, 2022 •
edited
Loading

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner February 22, 2022 07:45
@lukekarrys lukekarrys changed the base branch from latest to release-next February 22, 2022 07:45
@npm-robot
Copy link
Contributor

npm-robot commented Feb 22, 2022 •
edited
Loading

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 58.593 ±6.38 28.869 ±0.13 31.407 ±20.01 19.517 ±0.69 2.935 ±0.02 2.857 ±0.05 2.370 ±0.04 11.221 ±0.04 2.311 ±0.03 3.309 ±0.06
#4452 0.413 ±0.00 0.408 ±0.02 0.421 ±0.02 0.405 ±0.01 0.414 ±0.01 0.407 ±0.01 0.404 ±0.03 0.410 ±0.00 0.413 ±0.00 0.399 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 40.379 ±3.46 22.488 ±0.04 12.578 ±0.16 13.448 ±0.11 2.536 ±0.01 2.663 ±0.08 2.268 ±0.03 8.564 ±0.06 2.161 ±0.03 2.936 ±0.01
#4452 0.394 ±0.00 0.399 ±0.01 0.398 ±0.01 0.425 ±0.00 0.419 ±0.02 0.408 ±0.02 0.431 ±0.01 0.427 ±0.04 0.401 ±0.01 0.426 ±0.01

@lukekarrys lukekarrys changed the title feat(arborist): refactor arborist bin to use consisten timing/logging feat(arborist): refactor arborist bin to use consistent timing/logging Feb 23, 2022
nlf
nlf approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@nlf nlf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 this is great

@lukekarrys
feat(arborist): refactor arborist bin to use consistent timing/logging
72b34f4 
This attempts to make the arborist bin script behave more like the npm
cli with regards to the handing of timing and logging.

It also adds the a `logfile` argument to write logs to a file instead of
(or in addition to) stderr. This can be helpful for benchmarking
performance of loggins or terminal display.
@lukekarrys lukekarrys merged commit d438d61 into release-next Feb 24, 2022
@lukekarrys lukekarrys deleted the lk/arb-bin branch February 24, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@nlf nlf nlf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukekarrys @npm-robot @ljharb @nlf