feat: adding tests and updating docs to reflect changes in registry teams API. The default developers team can no longer be removed #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eams API. The default developers team can not longer be removed
nomadtechie
changed the title
miranda76
approved these changes
Nov 9, 2019
claudiahdz
pushed a commit
that referenced
this pull request
Nov 11, 2019
…stry teams API. The default developers team can not longer be removed PR-URL: #457 Credit: @nomadtechie Close: #457 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Nov 11, 2019
…stry teams API. The default developers team can not longer be removed PR-URL: #457 Credit: @nomadtechie Close: #457 Reviewed-by: @claudiahdz
claudiahdz
added
semver:patch
claudiahdz
pushed a commit
that referenced
this pull request
Nov 13, 2019
…stry teams API. The default developers team can not longer be removed PR-URL: #457 Credit: @nomadtechie Close: #457 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Nov 13, 2019
…stry teams API. The default developers team can not longer be removed PR-URL: #457 Credit: @nomadtechie Close: #457 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Nov 13, 2019
…stry teams API. The default developers team can not longer be removed PR-URL: #457 Credit: @nomadtechie Close: #457 Reviewed-by: @claudiahdz
claudiahdz
pushed a commit
that referenced
this pull request
Nov 13, 2019
…stry teams API. The default developers team can not longer be removed PR-URL: #457 Credit: @nomadtechie Close: #457 Reviewed-by: @claudiahdz
mikemimik
approved these changes
Nov 14, 2019
There was a problem hiding this comment.
LGTM
This pull-request was rebased into @claudiahdz's work and is present in #453
Merged
This was referenced Nov 27, 2019
This was referenced Dec 5, 2019
This was referenced Dec 18, 2019
This was referenced Jan 17, 2020
nomadtechie
deleted the
nomadtechie/updates-for-new-405-response-on-teams-api
branch
This was referenced Feb 25, 2020
This was referenced Mar 10, 2020
This was referenced Mar 19, 2020
This was referenced Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
The registry teams API has been updated to no longer allow the removal of the default developers team. This is PR updates the docs page for the
npm teamscmd and also adds a test to document the expected behavior and HTTP response.References