Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't die if manNumberRegex doesn't match the glob (#4610) #4611

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix: don't die if manNumberRegex doesn't match the glob (#4610) #4611

merged 1 commit into from
Mar 30, 2022
+60 −6

Commits on Mar 25, 2022

  1. fix: work better with system manpages (npm#4610) 

    In certain edge cases, the glob could find files that manNumberRegex wouldn't match.

A possible solution would be to try to bring the two closer, but since globs and regexes are different syntaxes, the two will never be exactly the same.
It's always asking for bugs; better to just handle the issue directly.

In addition, when npm is installed globally in a system directory, the
glob can find other manpages with similar names.
For instance "install.1", "init.1", etc. Preferring low-numbered
sections isn't enough in these cases; it's also necessary to prefer
the pages prefixed with "npm-".
    @d0sboots
    d0sboots committed Mar 25, 2022
    Configuration menu
    Copy the full SHA
    4993f89 View commit details
    Browse the repository at this point in the history