fix(arborist): when reloading an edge, also refresh overrides #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes some scenarios where overrides were not being properly applied, especially those where a node_modules or package-lock.json already exists
This was referenced Apr 7, 2022
|
no statistically significant performance changes detected timing results
|
2 tasks
Merged
oshi97
added a commit
to yext/answers-search-ui
that referenced
this pull request
Apr 18, 2022
There were a number of issues with npm overrides not being respected by the npm install command. Supposedly, these issues have been fixed in npm 8.7.0. See npm/cli#4709 This PR deletes and regenerates the package-lock so that overrides are respected. J=SLAP-2022 TEST=manual see that the unsafe-eval test page loads properly rerunning npm install does not undo overrides
oshi97
added a commit
to yext/answers-search-ui
that referenced
this pull request
Apr 18, 2022
There were a number of issues with npm overrides not being respected by the npm install command. Supposedly, these issues have been fixed in npm 8.7.0. See npm/cli#4709 This PR deletes and regenerates the package-lock so that overrides are respected. J=SLAP-2022 TEST=manual see that the unsafe-eval test page loads properly rerunning npm install does not undo overrides
oshi97
added a commit
to yext/answers-search-ui
that referenced
this pull request
Apr 18, 2022
There were a number of issues with npm overrides not being respected by the npm install command. Supposedly, these issues have been fixed in npm 8.7.0. See npm/cli#4709 This PR deletes and regenerates the package-lock so that overrides are respected. J=SLAP-2022 TEST=manual see that the unsafe-eval test page loads properly rerunning npm install does not undo overrides
oshi97
added a commit
to yext/answers-search-ui
that referenced
this pull request
Apr 19, 2022
There were a number of issues with npm overrides not being respected by the npm install command. Supposedly, these issues have been fixed in npm 8.7.0. See npm/cli#4709 This PR deletes and regenerates the package-lock so that overrides are respected. J=SLAP-2022 TEST=manual see that the unsafe-eval test page loads properly rerunning npm install does not undo overrides
oshi97
added a commit
to yext/answers-search-ui
that referenced
this pull request
Apr 19, 2022
There were a number of issues with npm overrides not being respected by the npm install command. Supposedly, these issues have been fixed in npm 8.7.0. See npm/cli#4709 This PR deletes and regenerates the package-lock so that overrides are respected. J=SLAP-2022 TEST=manual see that the unsafe-eval test page loads properly rerunning npm install does not undo overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when we load a virtual tree, we do it based on the package-lock structure setting only the root node in each constructor (not the parent, since we may not even have it yet). these changes ensure that even in this out-of-order scenario we still pick up the overrides on the child node, which means we more consistently apply overrides and identify when they are mismatched.