Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/remove ansistyles ansicolors #4728

Merged
merged 2 commits into from
Apr 13, 2022
Merged

Conversation

wraithgar
Copy link
Member

  • deps: remove ansistyles
  • deps: remove ansicolors

@wraithgar wraithgar requested a review from a team as a code owner April 11, 2022 13:39
@npm-robot
Copy link
Contributor

npm-robot commented Apr 11, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 66.373 ±4.76 37.621 ±0.19 22.888 ±0.06 26.689 ±0.64 3.816 ±0.01 3.928 ±0.07 3.150 ±0.05 15.604 ±0.01 3.068 ±0.00 4.266 ±0.15
#4728 67.575 ±4.66 39.008 ±0.17 23.742 ±0.37 25.976 ±0.74 3.789 ±0.00 3.770 ±0.00 3.008 ±0.00 15.536 ±0.18 2.938 ±0.03 5.146 ±1.38
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 60.791 ±13.01 30.410 ±0.15 27.670 ±14.32 19.085 ±0.15 3.616 ±0.04 3.590 ±0.00 3.198 ±0.14 12.138 ±0.17 3.028 ±0.03 4.037 ±0.13
#4728 51.325 ±1.68 29.996 ±0.31 17.898 ±0.02 18.998 ±0.31 3.679 ±0.03 3.563 ±0.05 3.278 ±0.14 11.807 ±0.23 2.993 ±0.12 3.955 ±0.00

@wraithgar wraithgar force-pushed the deps/remove-ansistyles-ansicolors branch from e8e5364 to 5e7a5c6 Compare April 11, 2022 14:18
@wraithgar
Copy link
Member Author

Discussed this at standup today, the snapshot differences are quirks and bugfixes and we really have been meaning to consolidate on chalk for awhile. Any weirdness anyone reports after this we can address individually. It's color output so it's not likely to really blow anyone's installs up or anything.

chalk is already in use elsewhere and does what we need
@lukekarrys lukekarrys force-pushed the deps/remove-ansistyles-ansicolors branch from 5e7a5c6 to 57bf36a Compare April 13, 2022 21:50
@fritzy fritzy merged commit c22fb1e into latest Apr 13, 2022
@fritzy fritzy deleted the deps/remove-ansistyles-ansicolors branch April 13, 2022 22:01
@lukekarrys lukekarrys mentioned this pull request Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants