Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove lib/utils/read-package-name.js #4757

Merged
merged 1 commit into from
Apr 19, 2022
Merged

Commits on Apr 16, 2022

  1. fix: remove lib/utils/read-package-name.js

    This code wasn't doing anything special, just dereferencing `name` from
    a packument.  There is no need for this to exist.
    
    Most of the tests were able to handle having this go away, except for
    `npm owner` which had to have its tests rewritten to be real, which of
    course surfaced bugs along the way of behavior that was incorrectly
    being tested.  `npm owner` needs some love to clean up its UX, it throws
    or returns inconsistently.  I did fix it so that if there is no
    package.json in cwd it errored as expected instead of throwing `ENOENT`
    which is what it did before.
    wraithgar committed Apr 16, 2022
    Configuration menu
    Copy the full SHA
    a2b0c94 View commit details
    Browse the repository at this point in the history