Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(init): allow for spec on scope-only arg #5206

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Jul 21, 2022

Closes #5175

@npm-cli-bot
Copy link
Collaborator

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 44.938 ±2.93 21.738 ±0.62 19.226 ±0.00 23.176 ±1.80 3.252 ±0.02 3.238 ±0.03 2.670 ±0.07 13.477 ±0.01 2.600 ±0.03 3.835 ±0.10
#5206 41.595 ±1.00 21.460 ±0.22 19.642 ±0.16 22.115 ±0.25 3.256 ±0.00 3.250 ±0.02 2.703 ±0.13 13.684 ±0.04 2.633 ±0.01 3.895 ±0.05
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 34.694 ±4.55 15.975 ±0.13 14.376 ±0.10 15.129 ±0.17 3.015 ±0.03 3.040 ±0.03 2.686 ±0.02 9.731 ±0.08 2.514 ±0.00 3.505 ±0.12
#5206 30.460 ±0.22 16.252 ±0.10 14.299 ±0.00 15.675 ±0.82 2.988 ±0.04 2.973 ±0.03 2.720 ±0.06 9.619 ±0.01 2.532 ±0.00 3.537 ±0.14

@darcyclarke darcyclarke added the semver:patch semver patch level for changes label Jul 26, 2022
@lukekarrys lukekarrys merged commit 0e3660e into latest Jul 27, 2022
@lukekarrys lukekarrys deleted the gar/init-scoped-spec branch July 27, 2022 21:04
@lukekarrys lukekarrys mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] version specifier doesn't work with scoped packages in npm init
4 participants