-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: display overrides in ls, explain and query #5306
Conversation
ef022bd
to
e8d8d71
Compare
no statistically significant performance changes detected timing results
|
it would be super nice if there was a way to view the actual shell diff (with full color) in-PR - i wonder if there's some kind of fancy github annotation action for that. |
e8d8d71
to
d13ad3a
Compare
i'm not sure what you mean, can you elaborate? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay new query selectors
@nlf i mean that viewing the raw snapshot diff is unhelpful; whereas getting a visual diff of the "before" and "after" shell output would make it quite clear what's changing. |
oooo, that would be nice if we could get an automatic before/after into the issue. sounds like a lot of work, but i made a note in my mad science notebook |
i was thinking an annotation, which is a github PR feature that would show it inline in the "diff" view and not on the discussion view. |
@@ -54,7 +54,7 @@ The [`npm query`](/commands/npm-query) commmand exposes a new dependency selecto | |||
- [`:private`](https://docs.npmjs.com/cli/v8/configuring-npm/package-json#private) when a dependency is private | |||
- `:link` when a dependency is linked (for instance, workspaces or packages manually [`linked`](https://docs.npmjs.com/cli/v8/commands/npm-link) | |||
- `:deduped` when a dependency has been deduped (note that this does *not* always mean the dependency has been hoisted to the root of node_modules) | |||
- `:override` when a dependency is an override (not implemented yet) | |||
- `:overridden` when a dependency has been overridden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HELL YEAH
No description provided.