Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: fix -S argument passing for sign-git-commit #58

Merged
merged 1 commit into from
Aug 29, 2018

Conversation

zkat
Copy link
Contributor

@zkat zkat commented Aug 24, 2018

Oops: 7984206 did the
wrong thing with the git params, and it breaks anyone
trying to sign their git commits with npm version.

Fixes: https://npm.community/t/1661
Credit: @zkat

/cc @dpogue

Oops: 7984206 did the
wrong thing with the git params, and it breaks anyone
trying to sign their git commits with npm version.

Fixes: https://npm.community/t/1661
Credit: @zkat
@zkat zkat added the semver:patch semver patch level for changes label Aug 24, 2018
@zkat zkat requested a review from a team as a code owner August 24, 2018 20:01
@zkat zkat merged commit 89652cb into release-next Aug 29, 2018
@zkat zkat deleted the zkat/fix-sign-commit-version branch August 29, 2018 18:42
zkat added a commit that referenced this pull request Dec 10, 2018
Oops: 7984206 did the
wrong thing with the git params, and it breaks anyone
trying to sign their git commits with npm version.

Fixes: https://npm.community/t/1661
Credit: @zkat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant