Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: [email protected] and all related deps #5933

Merged
merged 7 commits into from
Dec 7, 2022
Merged

deps: [email protected] and all related deps #5933

merged 7 commits into from
Dec 7, 2022

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys requested a review from a team as a code owner December 7, 2022 21:00
@lukekarrys lukekarrys changed the title lk/deps deps: [email protected] and all related deps Dec 7, 2022
@wraithgar
Copy link
Member

That's a lot of duping of 3 down into the tree. Are there other packages we control that need to get on minipass@4 first?

@nlf
Copy link
Contributor

nlf commented Dec 7, 2022

some of them are ours, but not all i don't think.. here's a list of everything still on minipass@3 for our future selves:

  • fs-minipass
  • minipass-collect (not ours)
  • minipass-fetch
  • minipass-flush (not ours)
  • minipass-json-stream (not ours)
  • minipass-pipeline (not ours)
  • minipass-sized (not ours)
  • minizlib (not ours)
  • node-gyp (not ours)

@lukekarrys
Copy link
Contributor Author

lukekarrys commented Dec 7, 2022

fs-minipass isn't on template-oss yet so that didn't get updated. minipass-fetch did get updated to minipass@4 but it also depends on minizlib and minipass-sized.

Is this worth merging in the meantime even though we are at minipass@4 used by 7 deps and minipass@3 used by 9?

@lukekarrys
Copy link
Contributor Author

Got some data on tarball size from packing before and after this PR showing the total increase in tarball size is 14.08 kB after gzip.

latest

❯ node . pack

npm notice === Tarball Details ===
npm notice name:          npm
npm notice version:       9.1.3
npm notice filename:      npm-9.1.3.tgz
npm notice package size:  2.4 MB
npm notice unpacked size: 9.7 MB
npm notice shasum:        b4e60b63041e1c582c44ad570ab94c3cd50bb343
npm notice integrity:     sha512-/lKNkqYzebc6D[...]ZCIrmu53DapjA==
npm notice bundled deps:  194
npm notice bundled files: 0
npm notice own files:     2031
npm notice total files:   2031
npm notice
npm-9.1.3.tgz

❯ stat --printf="%s" npm-9.1.3.tgz
2421762

this PR

❯ node . pack

npm notice === Tarball Details ===
npm notice name:          npm
npm notice version:       9.1.3
npm notice filename:      npm-9.1.3.tgz
npm notice package size:  2.4 MB
npm notice unpacked size: 9.9 MB
npm notice shasum:        e1fc2455a8213229302c564f10b936dd5628fa52
npm notice integrity:     sha512-Dfp6DxTxZleO1[...]6Xs1097wM69HQ==
npm notice bundled deps:  194
npm notice bundled files: 0
npm notice own files:     2067
npm notice total files:   2067
npm notice
npm-9.1.3.tgz

❯ stat --printf="%s" npm-9.1.3
2435842

@lukekarrys lukekarrys merged commit 0a3fe00 into latest Dec 7, 2022
@lukekarrys lukekarrys deleted the lk/deps branch December 7, 2022 22:24
@github-actions github-actions bot mentioned this pull request Dec 7, 2022
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants