Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util.stripVTControlCharacters #7157

Merged
merged 2 commits into from
Jan 19, 2024
Merged

util.stripVTControlCharacters #7157

merged 2 commits into from
Jan 19, 2024

Conversation

wraithgar
Copy link
Member

  • deps: remove strip-ansi
  • fix: use util.stripVTControlCharacters instead of strip-ansi

@wraithgar wraithgar requested a review from a team as a code owner January 18, 2024 21:26
@wraithgar
deps: remove strip-ansi
0aae547 
Only removes from direct dependencies, is still a non-dev subdependency
fritzy
fritzy approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@fritzy fritzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😎

lib/commands/outdated.js
@@ -1,5 +1,6 @@
const os = require('os')
const { resolve } = require('path')
const os = require('node:os')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a plan to update all node modules require statements with the prefix?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far no, just updating as we go.

@karenjli
Copy link

Is there a ticket associated to this PR? Where can I find more context about this change?

@wraithgar
Copy link
Member Author

No there is no ticket. It was just a clean up / follow up based on learning about that method when doing #7113

@wraithgar wraithgar merged commit 739634d into latest Jan 19, 2024
20 checks passed
@wraithgar wraithgar deleted the gar/stripvt branch January 19, 2024 20:26
@github-actions github-actions bot mentioned this pull request Jan 19, 2024
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fritzy fritzy fritzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wraithgar @karenjli @fritzy