Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(package-json): Reword warning about publishing local dependencies #7168

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

DanKaplanSES
Copy link
Contributor

Original: should not be used when publishing packages to the public registry.
New     : should not be used when publishing your package to the public registry.

When I read the original phrase, I interpreted it to mean, "Don't publish your package publicly if other packages depend on yours as a local dependency." Although I quickly realized the intended meaning, I believe I would've understood it from the get-go if it were written this new way.

(FWIW, I don't have a strong opinion about this and welcome any feedback.)

References

@DanKaplanSES DanKaplanSES requested a review from a team as a code owner January 22, 2024 20:03
@wraithgar wraithgar merged commit 2b7eaad into npm:latest Jan 22, 2024
8 checks passed
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants