Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more deps updates #7498

Merged
merged 5 commits into from
May 10, 2024
Merged

Even more deps updates #7498

merged 5 commits into from
May 10, 2024

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys requested a review from a team as a code owner May 9, 2024 22:33
@lukekarrys lukekarrys changed the title lk/even more deps Even more deps updates May 9, 2024
@@ -4,7 +4,7 @@
"description": "Manage node_modules trees",
"dependencies": {
"@isaacs/string-locale-compare": "^1.1.0",
"@npmcli/fs": "^3.1.0",
"@npmcli/fs": "^3.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not do this in workspaces?

@wraithgar wraithgar merged commit e189873 into latest May 10, 2024
60 checks passed
@wraithgar wraithgar deleted the lk/even-more-deps branch May 10, 2024 15:44
@wraithgar
Copy link
Member

We already are bumping all the workspaces in this release so we don't have to revert the package.json changes here. In the future we should stop doing that, they're packages not bundles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants