fix(cache): add limit for PackumentCache.heapLimit #7589
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
The current implementation of PackumentCache gets
heapLimit
value from the node runtime. But, in bun, theheap_size_limit: Infinity
by default, and it seems there is no way to limit it.Then, the
heapLimit
value passes to lru-cache cache with doesn't work with unlimited cache size at all.Trace from
lru-cache
:Solution
Let's set a reasonable maximum to the
heapLimit
to avoid this.