fix: always set exit code if exiting uncleanly #7674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An erroneous assumption was that if this was explicitly set, then the exit was still intentional. This is not the case.
hashtagchris
approved these changes
Jul 19, 2024
| t.strictSame(logs, []) | ||
| t.strictSame(errors(), [''], 'one empty string') | ||
| t.equal(process.exitCode, 1) |
There was a problem hiding this comment.
Optional: Add a dedicated test that verifies 0 is replaced by a non-zero value. The test name might make things click for someone.
Co-authored-by: Chris Sidi <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An erroneous assumption was that if this was explicitly set, then the exit was still intentional. This is not the case.
Closes: #7672