Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link as code in npm-ci #94

Closed
wants to merge 1 commit into from
Closed

Conversation

edouard-lopez
Copy link

@edouard-lopez edouard-lopez commented Nov 13, 2018

related: #92


Link to npm-install doc is shown as code:

selection_216

Removing the backtick surrounding it should fix this.

link was show as code instead of HTML
@edouard-lopez edouard-lopez requested a review from a team as a code owner November 13, 2018 16:08
@olleolleolle
Copy link

There are more of these, scattered around the doc/cli/ directory.

@olleolleolle
Copy link

olleolleolle commented Nov 18, 2018

One of these has been fixed in #92 - by changing the markdown renderer.

@sidvishnoi
Copy link

sidvishnoi commented Nov 30, 2018

There is no issues page, so reporting here. There seems some issue in build script, which I fail to understand. I don't think removing the backticks is a good solution. If we keep the backticks and fix the linking, we should have a link like <a href="URL"><code>TEXT</code></a>, which I think is the intention of those backticks. Someone needs to look into the build script. (I could've tried a fix myself, but I've exams. So maybe later)

image

Update: Came across this https://npm.community/t/links-to-npm-config-in-clear-text/3376/4

@zkat
Copy link
Contributor

zkat commented Dec 6, 2018

This has been fixed on the docs site, so we don't need to pick this up. It'll be online soon if not already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants